-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make check should include the unit test cases #31
Comments
Actually 'make check-local' just verifies code integrity (pep8 and stuff) if you're considering Kimchi as a base. It is 'make check' that should run the code integrity check of check-local and the unit tests too. |
Daniel, I just cross checked, make check and make check-local both execute the test cases in case of wok framework.and kimchi plugin. bash-4.3# pwd content of Makefile.am has On the same lines i was assuming i had to update the Makefile.am in ginger tests(ginger/tests/makefile.am) with below content, Let me know if this is fine? |
We're talking about different files. I was talking about make check-local at project root. For example, in Kimchi:
Note that the tests aren't run after firing "make check-local" at Kimchi root. Same thing with wok. However, I just verified that the change you've proposed (without the /data/screenshots line because we do not have that in Ginger) in tests/Makefile.am allows 'make check' from Ginger root to run the unit tests as well. So go ahead and make the change. Pay attention to the TAB indentation at Makefile.am, otherwise it will fail. And, if I may suggest, you can enhance the 'check-local' target at Ginger root to do the same steps as Kimchi/Wok. As far as I just checked here it is simply a matter of adding the line
At the start of the check-local target at Makefile.am of Ginger root (disclaimer: I've not tested it, just speculating). You can add this change in this same patch/issue if you like. Daniel |
@abhiramkulkarni let me know if you're still interested in doing this enhancement |
Will be working on this issue in coming weeks |
This patch adds the 'check-local' target in tests/Makefile.am to allow the unit tests to be ran when issuing 'make check' from Ginger root. Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Whenever make check-local is executed , the unit test cases also should be executed.
This helps in doing some basic test case execution for any patch being proposed.
The text was updated successfully, but these errors were encountered: