Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure:1987: error: package version not defined #9

Closed
frediz opened this issue Jan 20, 2015 · 1 comment
Closed

configure:1987: error: package version not defined #9

frediz opened this issue Jan 20, 2015 · 1 comment

Comments

@frediz
Copy link

frediz commented Jan 20, 2015

Hi,
I get the tarball of ginger from github to produce a debian package :
https://github.com/kimchi-project/ginger/tags and after running autoreconf,
the configure fails with :

configure: error: package version not defined

This seems to be due to PKG_VERSION not defined and checking further,
it should be defined by build-aux/pkg-version :

PKG_VERSION=`git describe --tags --match "ginger-[0-9]*" 2> /dev/null || cat VERSION 2> /dev/null`

Even if I put a build dependency to git in the debian environment, there is no .git in the tarball and the VERSION file is not there either. The latter should be produced from Makefile :

VERSION:
        @if test -d .git; then                                \
                git describe --abbrev=0 > $@;                     \
        fi

it is supposed to be generated as a result of make dist before delivering the tarball.

For now, I've patched pkg-version with the hardcoded version of ginger in the debian package :

-PKG_VERSION=`git describe --tags --match "ginger-[0-9]*" 2> /dev/null || cat VERSION 2> /dev/null`
+PKG_VERSION=`git describe --tags --match "ginger-[0-9]*" 2> /dev/null || echo ginger-1.3.0 2> /dev/null`

But I guess the source tarballs should provided a VERSION file already.

danielhb added a commit that referenced this issue Feb 19, 2015
Issues #9 and #10 describe errors related to the absence of the
VERSION file in the zip/tarball downloaded from Ginger webpage
in Github. This happens because Github does not include in the
compressed file any file that are in .gitignore. Excluding the
VERSION file from .gitignore fixes both issues.

Issue #12 says that the ChangeLog is missing from the zip/tarball.
This was fixed before in a previous commit, but to make it
available we need to retag Ginger to force Github to create
a new tarball.

There's also a minor issue with the previous naming used for the
Ginger tags. Naming the tags as 'ginger-<version>' forces Github
to create a tarball with name 'ginger-<tag>', thus the file name
becomes 'ginger-ginger-<version>'. Since we need to retag the
project due to these issues, the tag name will be changed to
just '<version>'. To reflect that, pkg-version was changed.

Signed-off-by: Daniel Henrique Barboza <dhbarboza82@gmail.com>
@frediz
Copy link
Author

frediz commented Feb 19, 2015

Tested and OK,
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant