design UI display unnormal when build a burnet package and install it firstly. #18
Comments
|
Note that this can eventually be fixed properly by adopting an autotools based build system and properly specifying the build dependencies. For now I would approve a short-term fix that manually triggers the appropriate distutils build from within the package build process. |
|
This is too bad for the fresh user of Kimchi. |
ghost
assigned
|
Fixed by: 0e2801e. Please reopen if you continue to encounter problems. |
patchew-importer
pushed a commit
to patchew-project/kimchi
that referenced
this issue
Apr 23, 2018
This requirement started in a fixed Gingerbase bug (kimchi-project#18) that reported lscpu problems when running in a French environment. The output was being translated to french and breaking the parsing made by the backend. This is such a powder keg for all the plug-ins that I believe this patch is justified. Instead of forcing en_US language by using subprocess.Popen and setting the env, this is how run_command will behave now: - A new optional attribute, env_vars, was added. As the name suggests, it allows the setup of the environment variables to run the command. - If env_vars is not set, run_command will copy the current environment variables and set the language to the default (en_US) by setting LC_ALL='C' variable. As of now, this is the case of all the existing run_command calls in the code for all WoK plug-ins. No behavior change will happen. - If env_vars is set, but the LC_ALL var isn't, run_command will set it to 'C' and force the default language. - If env_vars is set and LC_ALL is also set, run_command will not touch it and will run with env_vars as is. This allows the caller to set the language at will. Signed-off-by: Daniel Henrique Barboza <dhbarboza82@gmail.com>
patchew-importer
pushed a commit
to patchew-project/kimchi
that referenced
this issue
May 25, 2018
This requirement started in a fixed Gingerbase bug (kimchi-project#18) that reported lscpu problems when running in a French environment. The output was being translated to french and breaking the parsing made by the backend. This is such a powder keg for all the plug-ins that I believe this patch is justified. Instead of forcing en_US language by using subprocess.Popen and setting the env, this is how run_command will behave now: - A new optional attribute, env_vars, was added. As the name suggests, it allows the setup of the environment variables to run the command. - If env_vars is not set, run_command will copy the current environment variables and set the language to the default (en_US) by setting LC_ALL='C' variable. As of now, this is the case of all the existing run_command calls in the code for all WoK plug-ins. No behavior change will happen. - If env_vars is set, but the LC_ALL var isn't, run_command will set it to 'C' and force the default language. - If env_vars is set and LC_ALL is also set, run_command will not touch it and will run with env_vars as is. This allows the caller to set the language at will. Signed-off-by: Daniel Henrique Barboza <dhbarboza82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First time to make the burnet package. Setup.py just generates i18n files,
burnet.min.js and theme-default.min.css. But Setup.py does not not copy
them to the build directory.
The text was updated successfully, but these errors were encountered: