Integrate websockify into cherrypy

[aglitke]

noVNC is supported in Kimchi by launching an external program (websockify.py) to wrap an existing qemu vnc connection with web sockets (needed by noVNC). This works but has a number of disadvantages:

• Requires a range of ports to be opened through the firewall (to support multiple connections)
• Need to manage and clean up the spawned websockify processes.
• Complex

Anthony proposed an idea to support websocket proxying directly from the cherrypy server on its given port. The noVNC code would be directed to a URL such as: ws://:8000/vms/vm-1/vnc. Cherrypy would switch to a websockets handler to service connections at this URL.

[lvroyce]

I wander if I can take this one?

[aglitke]

Sure... I will assign it to you.

[shaohef]

@lvroyce, this issue is pending on 5 months. please fix it ASAP.
Thanks.

[shaohef]

duplicate with issue 90
#90

[alinefm]

Issue #90 is about using a single instance of websockify to handle all kimchi connections (instead of create one instance per connection)

And this issue is about incorporate websockify into cherrypy that way we can eliminate the use of websockify script.

[shaohef]

actually, @wudx05 can fix the the #90 by token.
after his patch, he can satisfy the requires of this issue #22
1. just requires one port to be opened through the firewall
2. do not need more than one websockify process.

[shaohef]

@wudx05 any comments?

[wudx05]

I don't see any other benefits to incorporate websockify into cherrypy. Aline, could you please elaborate why we need incorporate websockify into cherrypy? IMO, we can close this issue

[lvroyce]

This already fixed by Markwu.

[alinefm]

@wudx05 As proposed by Adam, integrating websockify into cherrypy can eliminate the need of manage and clean up the spawned websockify processes.

[alinefm]

Kimchi does not launch an external process for websockify anymore.
Instead of that, Kimchi is relying on python-websockify to enable the websockets connection
(commit 613650d)
Based on that, I don't think this issue makes sense in the current scenario.
I will close it by now, but feel free to reopen if you think anything else can be done on that area.