Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu - Distrubution packaging #25

Open
alinefm opened this issue Jan 11, 2016 · 6 comments
Open

Ubuntu - Distrubution packaging #25

alinefm opened this issue Jan 11, 2016 · 6 comments
Assignees
@lcorreia
Labels
feature
Milestone
Backlog

Comments

@alinefm
Copy link
Member

alinefm commented Jan 11, 2016

Identify what is needed to have wok package included in the Ubuntu official repositories.
@alinefm alinefm added this to the Backlog milestone Jan 11, 2016
@frediz
Copy link
Contributor

frediz commented Jan 12, 2016

Hi Aline,
So mainly, what is needed is

  1. the debian/ directory to run dpkg-buildpackage which describe the content, copyright, technical build, and is the official way to built packages. The way it's done atm will not be accepted.
  2. a RFS(request for sponsorship)/ITP(intent to package) bug on Debian bugzilla because Ubuntu will just sponsor this bug in Debian and then will include it in Ubuntu (or include it straight away before Debian inclusion, but in any case, Ubuntu dev. will want a bug on Debian bugzilla first). This bug will ask to include the software in the Debian archive and the above tarball of the debian/ directory should be attached or provided on debian.mentors.net .
  3. as few patches as possible in the debian/patches directory : those patches are applied on top of
    the software source to fix major issues or to comply with Debian/Ubuntu policy. These patches should be as minimal as possible and be upstreamed when possible.
  4. provide all dependency packaging if some software used to build the package are not in the Debian/Ubuntu archive.

As you know, I've been working on the packaging of kimchi/ginger and now also on wok and gingerbase for debian and ubuntu.
kimchi 1.5.0 is actually already included in Ubuntu : https://launchpad.net/ubuntu/+source/kimchi and I'm pushing on debian side as well : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800966 .

I saw kimchi/wok is undergoing a redesign and I've created the packing for Debian/Ubuntu for wok/kimchi/gingerbase 2.0.0 last week.
It needs a bit of improvement but :

  1. I can provide debian/ packaging
  2. I can open ITP/RFS bugs missing, that is for gingerbase and wok which are new.
  3. patches are not big, but we can discuss what we can/cannot include upstream
  4. it should be ok; I saw you are now using sassc to build css from scss and packaged it for Debian and it got accepted already : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804697

Fred

@frediz
Copy link
Contributor

frediz commented Apr 18, 2016

With the new version 2.1.0 of wok/kimchi/gingerbase, I updated my packaging.
I'm still having a few issues, which will prevent adoption of wok/related projects into Debian/Ubuntu
especially :

These are currently my main concern.

@pvital
Copy link
Contributor

pvital commented Apr 19, 2016

Hello @frediz

In addition to your points, we also have the issue #97 - Debian's name for libvirt service is libvirtd instead of libvirt-bin used by Ubuntu.

Regarding your second point, I guess Julien Goodwin (@laptop006) can submit again a new patch where don't starts nginx (whithout the apache stuff) and then we can solve this issue.

IMO, the other points can be submitted again the RFC's and pacthes.

alinefm pushed a commit that referenced this issue Jul 26, 2016
@alinefm
Use system's nginx proxy service.
4cbb1b9 
This patch removes the code that executes a dedicated nginx proxy, making Wok
to use the system's nginx service. This is a requirement to make Wok acceptable
in community repositories.

It also make sure that a Wok executed from path different than installed (from
a cloned and builded source code, for example) will create a symbolic link in
system's nginx config dir to the running configuration file.

This patch solves part of issue #25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue Oct 10, 2016
@alinefm
Add support to relative paths.
78f218d 
This patch adds support to handle the use of relative paths in configuration and
command line, as well, set the backend to use the new path in URL's.

This is part of solution to:
kimchi-project/kimchi#733
and
#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue Oct 10, 2016
@alinefm
Fix UI to handle relative paths.
f1453e5 
Updated necessary SCSS, JS and HTML files to handle the usage of
relative paths.

This is part of solution to:
kimchi-project/kimchi#733
and
#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
alinefm pushed a commit that referenced this issue Oct 10, 2016
@alinefm
CSS updates to handle relative path support.
5ffb7fe 
This is part of solution to:
kimchi-project/kimchi#733
and
#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
alinefm pushed a commit to alinefm/wok that referenced this issue Nov 10, 2016
@alinefm
Add support to relative paths.
5fb3cb1 
This patch adds support to handle the use of relative paths in configuration and
command line, as well, set the backend to use the new path in URL's.

This is part of solution to:
kimchi-project/kimchi#733
and
kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
alinefm pushed a commit to alinefm/wok that referenced this issue Nov 10, 2016
@alinefm
Fix UI to handle relative paths.
bb65838 
Updated necessary SCSS, JS and HTML files to handle the usage of
relative paths.

This is part of solution to:
kimchi-project/kimchi#733
and
kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
alinefm pushed a commit to alinefm/wok that referenced this issue Nov 10, 2016
@alinefm
CSS updates to handle relative path support.
03fa1b1 
This is part of solution to:
kimchi-project/kimchi#733
and
kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
lcorreia pushed a commit to lcorreia/wok that referenced this issue Jan 18, 2017
Add support to relative paths.
9c3e375 
This patch adds support to handle the use of relative paths in configuration and
command line, as well, set the backend to use the new path in URL's.

This is part of solution to:
kimchi-project/kimchi#733
and
kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
lcorreia pushed a commit to lcorreia/wok that referenced this issue Jan 18, 2017
Fix UI to handle relative paths.
b265a98 
Updated necessary SCSS, JS and HTML files to handle the usage of
relative paths.

This is part of solution to:
kimchi-project/kimchi#733
and
kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
lcorreia pushed a commit to lcorreia/wok that referenced this issue Jan 18, 2017
CSS updates to handle relative path support.
b2ba9ff 
This is part of solution to:
kimchi-project/kimchi#733
and
kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue May 25, 2018
@alinefm
Add support to relative paths.
ae0c597 
This patch adds support to handle the use of relative paths in configuration and
command line, as well, set the backend to use the new path in URL's.

This is part of solution to:
kimchi-project#733
and
kimchi-project/wok#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue May 25, 2018
@alinefm
Fix UI to handle relative paths.
90acac3 
Updated necessary SCSS, JS and HTML files to handle the usage of
relative paths.

This is part of solution to:
kimchi-project#733
and
kimchi-project/wok#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
patchew-importer pushed a commit to patchew-project/kimchi that referenced this issue May 25, 2018
@alinefm
CSS updates to handle relative path support.
b4621db 
This is part of solution to:
kimchi-project#733
and
kimchi-project/wok#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
patchew-importer pushed a commit to patchew-project/kimchi-wok that referenced this issue May 25, 2018
@alinefm
Use system's nginx proxy service.
92e76f0 
This patch removes the code that executes a dedicated nginx proxy, making Wok
to use the system's nginx service. This is a requirement to make Wok acceptable
in community repositories.

It also make sure that a Wok executed from path different than installed (from
a cloned and builded source code, for example) will create a symbolic link in
system's nginx config dir to the running configuration file.

This patch solves part of issue kimchi-project#25

Signed-off-by: Paulo Vital <pvital@linux.vnet.ibm.com>
@Fantu
Copy link

Fantu commented Sep 9, 2019 •
edited
Loading

I started to prepare debian packaging for debian upload
Fantu@c055f28
this is only partial for now...
in debian/control I tried to put all correct build-deps and deps but I have some questions/problems:

  • there is python-m2crypto used by src/wok/sslcert.py (by fast grep) that seems still python2 but with python2 things I suppose will be rejected (next debian version will drop python2), can be checked and modified for python3 if needed please?
    Edit: on #debian-devel confirmed that new packages with python2 will be not accepted
  • python3-jsonschema>= 3 for draft7 support but in debian repo is still not present :( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939943
  • there are some dev requirement added with "sudo -H pip3 install -r requirements-dev.txt" based on docs, in debian repo I saw only https://packages.debian.org/source/sid/libsass and https://packages.debian.org/source/sid/cython but not pre-commit, are always needed?
    Edit: from #debian-devel confirmed that is will be not accepted upload of packages not installable (including needed pip for install deps.)

debian/copyright need to be improved/completed (I mainly autogenerate it with decopy), without it with full and correct license list make package reject
I keeped debhelper to 11 (instead 12) to make possible use it also on older debian and ubuntu but probably with python3 deps very recent I suppose will be difficult

any help is appreciated, I'm doing some very fast thing because the time is too few and my python knowledge is almost nothing, sorry also for my bad english

@alinefm
Copy link
Member Author

alinefm commented Sep 20, 2019 •
edited
Loading

Hi @Fantu

Thank you for the initiative to get Kimchi into debian!

  • there is python-m2crypto used by src/wok/sslcert.py (by fast grep) that seems still python2 but with python2 things I suppose will be rejected (next debian version will drop python2), can be checked and modified for python3 if needed please?

I will take a look on this.

Will it be added or not?

It is only for development purposes. We don't need to include them as part of the debian package.

debian/copyright need to be improved/completed (I mainly autogenerate it with decopy), without it with full and correct license list make package reject

I will take a look.

@Fantu
Copy link

Fantu commented Sep 25, 2019

small update: python-jsonschema 3 was prepared and uploaded into experimental today but blocked by python-pyrsistent dep missed in NEW queue since 7 months, after was reuploaded also python-pyrsistent without python2 part and I suppose will be acceptedbut I do not know when

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcorreia lcorreia

Labels
feature
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@pvital @lcorreia @Fantu @alinefm @frediz