Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode of ident should only happen if it is of type unicode. #41

Closed
archu-s opened this issue Mar 21, 2016 · 0 comments
Closed

encode of ident should only happen if it is of type unicode. #41

archu-s opened this issue Mar 21, 2016 · 0 comments
Assignees
@archu-s
Labels
bug
Milestone
Wok 2.1

Comments

@archu-s
Copy link

archu-s commented Mar 21, 2016

Current in base.py, line 73, ident is getting encode even if it is not of type unicode. So encode will give incorrect result of encoding if ident is not of type unicode.
alinefm pushed a commit that referenced this issue Mar 23, 2016
@alinefm
Issue #41: encode of ident should only happen if it is of type unicode.
d11ff49 
Added isinstance unicode check of ident before encoding it.

Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com>
@alinefm alinefm added the bug label Mar 23, 2016
@alinefm alinefm closed this as completed Mar 23, 2016
@alinefm alinefm added this to the Wok 2.1 milestone Mar 23, 2016
patchew-importer pushed a commit to patchew-project/kimchi-wok that referenced this issue May 25, 2018
@alinefm
Issue kimchi-project#41: encode of ident should only happen if it is …
198480b 
…of type unicode.

Added isinstance unicode check of ident before encoding it.

Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archu-s archu-s

Labels
bug
Projects
None yet
Milestone
Wok 2.1
Development

No branches or pull requests
2 participants
@alinefm @archu-s