Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making wok.message closeable even if container/node for message is given. #9

Closed
archu-s opened this issue Dec 16, 2015 · 0 comments
Closed

Making wok.message closeable even if container/node for message is given. #9

archu-s opened this issue Dec 16, 2015 · 0 comments
Assignees
@archu-s
Labels
enhancement
Milestone
Wok 2.0

Comments

@archu-s
Copy link

archu-s commented Dec 16, 2015

Currently wok.message implmentation does not give option to make it closeable instead of fading it out if container for the message is given i.e if container for the message is other than default node "#alert-fields".
alinefm pushed a commit that referenced this issue Dec 16, 2015
@alinefm
Issue #9: Making wok.message closeable even if container/node for mes…
44204f0 
…sage is given.

Modified code to have one more paramter as closeable, if passed
with value as true then it add the close button to message node.
Otherwise if not passed or passed with value false then
there is no change in previous behaviour.

Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com>
@alinefm alinefm added this to the Wok 2.0 milestone Dec 16, 2015
@alinefm alinefm closed this as completed Dec 16, 2015
patchew-importer pushed a commit to patchew-project/kimchi-wok that referenced this issue May 25, 2018
@alinefm
Issue kimchi-project#9: Making wok.message closeable even if containe…
be82c24 
…r/node for message is given.

Modified code to have one more paramter as closeable, if passed
with value as true then it add the close button to message node.
Otherwise if not passed or passed with value false then
there is no change in previous behaviour.

Signed-off-by: Archana Singh <archus@linux.vnet.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archu-s archu-s

Labels
enhancement
Projects
None yet
Milestone
Wok 2.0
Development

No branches or pull requests
2 participants
@alinefm @archu-s