Use idiomatic "seq" instead of "not-empty" #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
To check for empty sequences, it's preferred to use "seq" in Clojure -- see the doc string of
(doc empty?)
. It might seem easier first to use "not-empty", but in that case a novice will not be able to understand idiomatic code. So I think you should teach the "seq" idiom instead of "not-empty".I also fixed a small typo on the way. :)
Thanks for your work, Clojure by Example is great!
Martin