Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use idiomatic "seq" instead of "not-empty" #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mzuther
Copy link

@mzuther mzuther commented Jun 2, 2019

Hi!

To check for empty sequences, it's preferred to use "seq" in Clojure -- see the doc string of (doc empty?). It might seem easier first to use "not-empty", but in that case a novice will not be able to understand idiomatic code. So I think you should teach the "seq" idiom instead of "not-empty".

I also fixed a small typo on the way. :)

Thanks for your work, Clojure by Example is great!

Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant