Optimization WalletWasabi#2

WalletWasabi/Stores/IndexStore.cs

@@ -1,9 +1,11 @@
+using Microsoft.Data.Sqlite;
 using NBitcoin;
 using Nito.AsyncEx;
 using System.Collections.Generic;
 using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
+using System.Transactions;
 using WalletWasabi.Backend.Models;
 using WalletWasabi.Blockchain.BlockFilters;
 using WalletWasabi.Blockchain.Blocks;
@@ -118,22 +120,36 @@ private bool TryProcessFilterNoLock(FilterModel filter, bool enqueue)
 
 	public async Task AddNewFiltersAsync(IEnumerable<FilterModel> filters, CancellationToken cancellationToken)
 	{
-		var successAny = false;
-
-		foreach (var filter in filters)
+		if (NewFilter is null)
 		{
-			var success = false;
+			// Lock once.
+			using IDisposable lockDisposable = await IndexLock.LockAsync(cancellationToken).ConfigureAwait(false);
+
+			using SqliteTransaction sqliteTransaction = IndexStorage.BeginTransaction();
 
-			using (await IndexLock.LockAsync(cancellationToken).ConfigureAwait(false))
+			foreach (FilterModel filter in filters)
 			{
-				success = TryProcessFilterNoLock(filter, enqueue: true);
+				// TODO: Should throw?
+				_ = TryProcessFilterNoLock(filter, enqueue: true);
 			}
 
-			successAny = successAny || success;
-
-			if (success)
+			sqliteTransaction.Commit();
+		}
+		else
+		{
+			foreach (FilterModel filter in filters)
 			{
-				NewFilter?.Invoke(this, filter); // Event always outside the lock.
+				bool success;
+
+				using (await IndexLock.LockAsync(cancellationToken).ConfigureAwait(false))
+				{
+					success = TryProcessFilterNoLock(filter, enqueue: true);
+				}
+
+				if (success)
+				{
+					NewFilter?.Invoke(this, filter); // Event always outside the lock.
+				}
 			}
 		}
 	}

WalletWasabi/Stores/SqliteStorage.cs

@@ -80,6 +80,15 @@ public static SqliteStorage FromFile(string path, FilterModel? startingFilter =
 		return storage;
 	}
 
+	/// <summary>
+	/// Begin a transaction.
+	/// </summary>
+	/// <seealso href="https://learn.microsoft.com/en-us/dotnet/standard/data/sqlite/transactions"/>
+	public SqliteTransaction BeginTransaction()
+	{
+		return Connection.BeginTransaction();
+	}
+
 	/// <summary>
 	/// Returns all filters with height ≥ than the given one.
 	/// </summary>