Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties style #133

Merged
merged 2 commits into from Oct 3, 2021
Merged

Properties style #133

merged 2 commits into from Oct 3, 2021

Conversation

dkhd
Copy link
Contributor

@dkhd dkhd commented Oct 2, 2021

Motivation

This issue here #72 and mention here #131

Changes

Enhance the UI for file/directory properties.

  1. Fixed width (but flexible height) with auto-break filename
  2. Capitalize the first letter of isHiddenFile
  3. Adding colon
  4. Increasing some padding & margin
  5. Format the date & time for Created At, Modified At, and Accessed At

See screenshots below

properties

properties

I also added MomentJS module to format the time, yarn.lock modified by system.

Related

This issue here #72 and mention here #131

Additional Comments

none

@vercel
Copy link

vercel bot commented Oct 2, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@Turbinya
Copy link
Contributor

Turbinya commented Oct 2, 2021

I think it's better to use Luxon instead of Moment https://moment.github.io/luxon/#/formatting?id=presets. Moment is very big, obsoleted and depricated.
Or try using: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/DateTimeFormat so as not to increase the size of the application at all

@dkhd
Copy link
Contributor Author

dkhd commented Oct 2, 2021

Nice suggestion @Turbinya, I'll take a look at it.

@vercel
Copy link

vercel bot commented Oct 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/FyKWgX5M2ZA7orEDeaby9a1qzgRp
✅ Preview: https://xplorer-git-fork-dkhd-properties-style-kimlimjustin.vercel.app

@kimlimjustin
Copy link
Owner

Both #131 and #133 proposed good styling, I think I'll combine these both PRs (by taking #131's center styling and other from this), also @dkhd do you realize that #132 code is also here?

@dkhd
Copy link
Contributor Author

dkhd commented Oct 3, 2021 via email

@kimlimjustin kimlimjustin added the hacktoberfest-accepted Work for your T Shirt label Oct 3, 2021
@kimlimjustin kimlimjustin merged commit ef5dd91 into kimlimjustin:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Work for your T Shirt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants