Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Active Tab Styling in Settings #141

Merged
merged 3 commits into from Oct 3, 2021
Merged

Added Active Tab Styling in Settings #141

merged 3 commits into from Oct 3, 2021

Conversation

stanleyowen
Copy link
Contributor

@stanleyowen stanleyowen commented Oct 3, 2021 •
edited

Motivation

Sometimes people find difficulties in recognizing which tab is currently opened. Therefore by adding some styling will allow them to cope with this issue.

Changes

  • Added setActiveTab function
  • Added Active Tab Styling
  • Set onmouseleave attribute to null when tab is active

Additional Comments

Light:
Light

Dark:
Dark

Light+:
Light+

Dark+:
Dark+

@vercel
Copy link

vercel bot commented Oct 3, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/2wurpts8JjvLk1f2RaVRg9bGjMTm
✅ Preview: https://xplorer-git-settingsactivetab-kimlimjustin.vercel.app

@stanleyowen stanleyowen self-assigned this Oct 3, 2021
@stanleyowen stanleyowen added the enhancement New feature or request label Oct 3, 2021
@stanleyowen stanleyowen marked this pull request as ready for review October 3, 2021 09:42
kimlimjustin
kimlimjustin approved these changes Oct 3, 2021
View reviewed changes
Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimlimjustin kimlimjustin merged commit c573240 into master Oct 3, 2021
@kimlimjustin kimlimjustin deleted the settings_active_tab branch October 3, 2021 11:46
@stanleyowen stanleyowen added the hacktoberfest-accepted Work for your T Shirt label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlimjustin kimlimjustin kimlimjustin approved these changes

Assignees

@stanleyowen stanleyowen

Labels
enhancement New feature or request hacktoberfest-accepted Work for your T Shirt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stanleyowen @kimlimjustin