New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added slide selection and fixed image overflow for small screen sizes #180
Added slide selection and fixed image overflow for small screen sizes #180
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel. @kimlimjustin first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/BAxJM8TZx5wzkSqwAh9exNnsjNHa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
We'll just wait for approves from @kimlimjustin / @stanleyowen. |
Wait, I kinda noticed an error with the slideshow, In 1 minute, I will make the video and post it here. It's best if this error is fixed now. |
2021-11-25.08-56-31.mp4Bug 1. The brightness in Xplorer blinds the text |
xplorer/docs/src/pages/index.jsx Line 23 in 12626e4
Just edit that to Xplorer's docs (kinda sounds unprofessional) or Documentation (professional).Edit: From 12626e4 |
Slideshow code: xplorer/docs/src/pages/slideshow.jsx Lines 5 to 34 in 12626e4
So, we need to modify the CSS to make the text readable when it's in light mode and dark mode. Since it's JSX, it could be possible. |
Sorry for late reply, I was in school and for the |
Well, kinda looks better with |
Motivation
This PR was created to improve the professionalism of the documentation site.
Changes
Updated docs image slideshow buttons
Updated the
docs/src/pages/slideshow.jsx
component to support user-selecting specific images within the slideshow. Previously users had to wait until the slideshow cycled to re-view an image. Now users can simply click on the dot corresponding to their desired image and that image will show. Note that after clicking on a dot the image will still cycle after a given period of time (configured in the component).These buttons can now be used to view specific images within the slideshow
Fixed small-screen docs image display
Currently images within the docs homepage (
docs/src/pages/index.jsx
) do not display properly on small screens. This was fixed using theobject-fit
CSS rule.Broken small-screen images
Fixed small-screen images
Related
No related PRs. No required documentation updates.
Additional Comments
No additional comments.