Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build wasn't testing anything, thus the code coverage fell to 0%. We were running against Circle's PHPUnit 6, which has namespace changes from 4.x/5.x. I am guessing it broke down when Circle upgraded their image with PHPUnit 6.
This PR spans a bit far for my liking, but here I am submitting it. I've broken this into four commits with an explanation for each:
Upgrade to PHPUnit 6. - 662a8db
I added PHPUnit 6.x as a dev dependency and fixed breaking changes.
Fix Illuminate requirements. - 4cf906d
I don't know how this was ever running inside Laravel 5.1. With 5.1, this was happening:
Update dev dependencies. - a72c9ac
Mockery went 1.0, finally, and I think the php-coveralls/php-coveralls package is the official package (same underlying repo). However, swapping the Coveralls package doesn't fix the
Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.
Check out php-coveralls/php-coveralls#203. If you can understand what its maintainer is trying to do, you're doing better than me.Upgrade to CircleCI 2.0. - 098cdeb
I've removed circle.yml, adding .circleci/config.yml for 2.0. 4 jobs are configured--a lowest and latest set of dependencies on both PHP 7.0 and 7.1. I'd configure PHP 7.2 if Circle had an image--didn't want to get into using a non-Circle image. Circle's Docker images are wayyy heavy though, something like 1.5GB (I'm sure they cache) and their config format needs some polish. Coveralls should handle the coverage for parallel builds--seems to be working in my fork.
Check out the builds here:
https://circleci.com/gh/aejnsn/temporal-models/tree/ci-upgrade-fixes
https://coveralls.io/github/aejnsn/temporal-models