Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Ember 3.7? #83

Closed
lougreenwood opened this issue Jan 20, 2019 · 8 comments
Closed

Incompatible with Ember 3.7? #83

lougreenwood opened this issue Jan 20, 2019 · 8 comments

Comments

@lougreenwood
Copy link

Seems that the recent changes around the router service in Ember 3.7 breaks the add-on.

After upgrading I started to get this error:

Build Error (prember)

Cannot read property 'setTitle' of undefined

After digging through my node modules for setTitle, the only hit was this add-on.

@The-Don-Himself
Copy link

Yes, getting this too, from document-title.js line 75

@alexis89x
Copy link

Seems that from Ember 3.7.0
self.router.setTitle should be changed into self._router.setTitle

@alexis89x
Copy link

Actually, it's this issue #16312, included in Ember 3.1.0. From Ember 3.7.0, the deprecated self.router has been removed.

@lougreenwood
Copy link
Author

Looks like we probably shouldn't expect this to be fixed if we consider the lack of response from @kimroen on #81 :(

@scottwernervt
Copy link

@mike-north made a fork https://github.com/mike-north/ember-cli-document-title-northm and I am currently using it in a project (eliminates the console warnings). I recommend creating an issue or pull request there.

noslouch pushed a commit to nypublicradio/gothamist-web-client that referenced this issue Apr 10, 2019
bkammin pushed a commit to nypublicradio/nypr-jukeboxes that referenced this issue Nov 20, 2019
bkammin pushed a commit to nypublicradio/nypr-jukeboxes that referenced this issue Nov 20, 2019
bkammin pushed a commit to nypublicradio/nypr-jukeboxes that referenced this issue Nov 20, 2019
bkammin pushed a commit to nypublicradio/nypr-jukeboxes that referenced this issue Nov 20, 2019
alexlafroscia added a commit to alexlafroscia/ember-steps that referenced this issue Jun 7, 2020
Resolution for running into kimroen/ember-cli-document-title#83 in Fastboot environment
@Benjy1979
Copy link

Is this issue still present? I'm getting it after just installing it now. self.router.setTitle(finalTitle); is crashing out.

@SparshithNR
Copy link

https://github.com/kimroen/ember-cli-document-title/blob/master/vendor/document-title/document-title.js#L73-L76
This change needs to be released. Code is merged, we need to cut a new version.
Changes made in #80

@snewcomer
Copy link
Collaborator

1.0 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants