Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid polluting the main:: namespace #1

Merged
merged 1 commit into from Jan 30, 2017

Conversation

dmaestro
Copy link
Contributor

Imports from Exporter and JSON were ending up in namespace main:: - this conflicts with code running with Dancer, for example.

Add package declaration before loading modules with use

Imports from Exporter and JSON were ending up in namespace main:: - this conflicts with code running with Dancer, for example.

Add package declaration before loading modules with `use`
Copy link
Owner

@kimryan kimryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@kimryan kimryan merged commit 8ec8e6d into kimryan:master Jan 30, 2017
@dmaestro dmaestro deleted the avoid_poluting_main_namespace branch January 30, 2017 15:01
@dmaestro
Copy link
Contributor Author

Hoping for a new release soon ... any plans?

@kimryan
Copy link
Owner

kimryan commented Feb 27, 2017

Will try to do one next week.

@dmaestro
Copy link
Contributor Author

dmaestro commented Mar 2, 2017

Thanks! Looking forward to it :-)

@dmaestro
Copy link
Contributor Author

dmaestro commented Mar 9, 2017

Version 2.02 is now out and works for me. Thanks, Kim! Issue in RT may be closed.

@kimryan
Copy link
Owner

kimryan commented Mar 11, 2017

Yes, I was waitng for CPAN testers to test it, but doesn't seem to be working. Will add to github soon. I had to change the package name in your update, Glad the module is useful for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants