Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previously selected menu items not deactivated with custom activate class #12

Closed
jbardon opened this issue Aug 27, 2020 · 0 comments
Closed

Previously selected menu items not deactivated with custom activate class #12

jbardon opened this issue Aug 27, 2020 · 0 comments

Comments

@jbardon
Copy link
Contributor

jbardon commented Aug 27, 2020

When a custom active class is provided, the class is well set on menu items.
Yet, it's not removed when the selected section changes.

const options = {
    activeClass: '.custom-class',
};
scrollSpy('#main-menu', options)
kimyvgy added a commit that referenced this issue Mar 22, 2021
@kimyvgy
release: 2.1.0
b3d8624 
✱ Features:
- adding some functionality for allowing user to define a
scrollContainer
([#17](#17)) (31e39d7)
✱ Bug Fixes:
- [#12](#12) Custom
active class not removed for previously selected menu items
([#13](#13)) (1cec086)
- defining non-existing 'scrollContainer' will work (2d3c408)
- the demo is not working in the localhost (41cf4b3)
kimyvgy added a commit that referenced this issue Mar 22, 2021
@kimyvgy
release: 2.1.0
d500efc 
✱ Features:
- adding some functionality for allowing user to define a scrollContainer ([#17](#17)) (31e39d7)
✱ Bug Fixes:
- [#12](#12) Custom active class not removed for previously selected menu items ([#13](#13)) (1cec086)
- defining non-existing 'scrollContainer' will work (2d3c408)
- the demo is not working in the localhost (41cf4b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbardon