partners 2014

[davojta]

adding partners in format suitable for cms page for cpm2014 from https://trello.com/c/gUxjsR7E/26-fixture-cpm2014-partners

[abitrolly]

That's not translated. Is there a strategy to get this done? Should these be left blank then?

[davojta]

it's for 1st milestone to release it untranslated.
After 1st milestone we will collect all untranslated text and will send them to translation coordinator for translate.

These data was always only on 1 lang.

[abitrolly]

I can LGTM this as is, but better if I spend some time to review that everything is ok.

[abitrolly]

relax450.png and where450.png - are they used anywhere?

[abitrolly]

100second.png usage is also questionable. JSON content LGTM.

[davojta]

These images will be used for other years, i can recheck them to exclude
used for these year

On Wed, Aug 24, 2016, 8:22 AM Anatoli Babenia notifications@github.com
wrote:

100second.png usage is also questionable. JSON content LGTM.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2i0lFB8F0yuL59bowOgeyfTxm9uxWzks5qi9URgaJpZM4JjAS5
.

[abitrolly]

Yes, it is better to add only images that are used to keep track of them.

[abitrolly]

@davojta extra images, see #43 for datacheck.py script:

C:\next.filmfest.by\data>py "datacheck.py"
.\raw\cpm2014_partners.json
  entries: 18
    error - extra 'raw\images\100second.png'
    error - extra 'raw\images\cinewest.png'
    error - extra 'raw\images\eksperiment.png'
    error - extra 'raw\images\relax450.png'
    error - extra 'raw\images\videomaker.png'
    error - extra 'raw\images\where450.png'

[davojta]

I plan rework this pr to make it more consistent. I will add data year by
year to repo from 2012 to 2016 in separate pr

On Thu, Aug 25, 2016, 9:10 AM Anatoli Babenia notifications@github.com
wrote:

@davojta https://github.com/davojta extra images, see #48 for
datacheck.py script:

C:\next.filmfest.by\data>py "datacheck.py"
.\raw\cpm2014_partners.json
entries: 18
error - extra 'raw\images\100second.png'
error - extra 'raw\images\cinewest.png'
error - extra 'raw\images\eksperiment.png'
error - extra 'raw\images\relax450.png'
error - extra 'raw\images\videomaker.png'
error - extra 'raw\images\where450.png'

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2i0hlQeCrXe_otVlv3_n9pJJIDwiYMks5qjTHQgaJpZM4JjAS5
.

[abitrolly]

Let's just remove extra files and commit it. It is already reviewed.

[abitrolly]

In other words, let's apply "progressive enhancement" methodology.

[davojta]

Okey, will try finish it soon)

On Thu, Aug 25, 2016, 4:01 PM Anatoli Babenia notifications@github.com
wrote:

In other words, let's apply "progressive enhancement" methodology.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2i0le40Qq_v1KYMds2-gj7H0Hpxj5iks5qjZIzgaJpZM4JjAS5
.

[abitrolly]

@davojta I can remove them for you and merge. Deal?

[davojta]

Okey, you can do it. i can do it tommorow morning)

On Thu, Aug 25, 2016, 11:27 PM Anatoli Babenia notifications@github.com
wrote:

@davojta https://github.com/davojta I can remove them for you and
merge. Deal?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#38 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2i0oxChN9FUMjUTFdGhIboS3PmuG25ks5qjfqkgaJpZM4JjAS5
.

[abitrolly]

My ningitsu > yours, so I'll do it faster. )

[abitrolly]

OMG, I screwed up rebase,

[abitrolly]

Good job, @davojta. =)