Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .deploy/ space and move nginx config there #83

Closed
wants to merge 1 commit into from

Conversation

abitrolly
Copy link
Member

No description provided.

@abitrolly abitrolly added this to the Milestone 2 milestone Dec 2, 2016
@staaas
Copy link
Collaborator

staaas commented Dec 2, 2016

@abitrolly can you briefly document your plan?
that will be easier to review prs having that in mind. we'll also be able to help with some steps if we understand your intensions.

@abitrolly
Copy link
Member Author

abitrolly commented Dec 2, 2016

@nott the plan for now is to move scripts related to deployment into .deploy/ dir

@abitrolly
Copy link
Member Author

abitrolly commented Dec 2, 2016

This particular PR is needed to make nginx config readable.

@staaas
Copy link
Collaborator

staaas commented Dec 2, 2016

i don't see much difference here

@abitrolly
Copy link
Member Author

nginx config can be put into repo root, but there is already too much files irrelevant to Django application there.

@staaas
Copy link
Collaborator

staaas commented Dec 8, 2016

@davojta what do you think?

@davojta
Copy link
Member

davojta commented Dec 8, 2016

I think move all deploy relate files to separate folder is good point. If it doent anything working right now.

@abitrolly
Copy link
Member Author

abitrolly commented Dec 8, 2016

I will get back to it in after 14th of December. Docker is awesome. @nott is there any tools to measure memory, CPU and disk space footprint of those containers? Ideally I want to run it and then freeze, and then get immediate and average values.

The point is to have bare minimum necessary for deployment in root, and move everything else to .deploy. This way I, as administrator, could get quick overview of deployment requirements without getting too deep into application structure.

@staaas
Copy link
Collaborator

staaas commented Jan 9, 2017

@abitrolly I have plans to get rid of nginx and replace it with haproxy
let's close this pr

@staaas staaas closed this Jan 14, 2017
@abitrolly abitrolly mentioned this pull request Jan 16, 2017
@abitrolly
Copy link
Member Author

@nott I don't see how HAProxy is different from Nginx in this context. I want the ability to edit and copy servers configs without Docker.

So if you agree that embedding config files for one app as strings into config files of other app is a bad pattern, let's discuss it further - where should we place your new HAProxy configs, so I can move current stuff there for now.

My problem with current solution "configs as Dockerfile stings" is that I can not read through quoted \n at line ends, and my syntax highlight doesn't work there.

@staaas
Copy link
Collaborator

staaas commented Jan 16, 2017

@abitrolly

I don't have strong opinion about place for configuration

  • if they are small, I see many benefits in embedding them into Dockerfiles
  • however I also see your concerns

We can just remove production.yml and Dockerfile-nginx for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants