-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application cpm_data to separate data from site structure #85
Conversation
There are now 2 copies of test image, so we'll switch to a more robust assertion.
@abitrolly @davojta could you please have a look? |
from modeladminutils.widgets import GenericModelChooser | ||
|
||
|
||
class BaseGenericModelChooserPanel(BaseChooserPanel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need separate panel and cant just use http://docs.wagtail.io/en/v1.7/topics/snippets.html for our models ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i doubt we can use snippets panel without actually using snippets
snippets is an easier approach
i think i should have used it instead of implementing this panel
but now when my widget is implemented, modeladmin approach opens more opportunities
@abitrolly is deploy/netlify failure expected? |
@davojta is this gtg? once we merge this i'll start converting data from |
I agree with that, go ahead ;-)
…On Thu, Dec 8, 2016, 5:10 PM Stas Rudakou ***@***.***> wrote:
@davojta <https://github.com/davojta> is this gtg? once we merge this
i'll start converting data from results
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2i0muSpna1MTjxTX99gucePzV0zilGks5rGA_ngaJpZM4LHSiB>
.
|
@davojta could you please approve this then? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds cpm_data application to separate data from site structure. My final goal is to get rid of Page objects that don't represent public site pages.
This was inspired by site menu (developed by @abitrolly).
![modeladmin](https://cloud.githubusercontent.com/assets/382950/20992305/4907a0ac-bcf4-11e6-9f8d-9c965d7ffa83.png)
wagtail.contrib.modeladmin
provides some tools for making independent admin-like CRUD interfaces (that still look like Wagtail). Looks like this module miss a lot of things. The main one is a generalized chooser panel (so I had to implement one). Also I miss Page-like revisions/publications.modeladminutils
contains our enahncements forwagtail.contrib.modeladmin
. I'll probably try to push them back towagtail.contrib.modeladmin
some time later.