Add application cpm_data to separate data from site structure #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are now 2 copies of test image, so we'll switch to a more robust assertion.
|
@abitrolly @davojta could you please have a look? |
davojta
reviewed
Dec 8, 2016
| from modeladminutils.widgets import GenericModelChooser | ||
|
|
||
|
|
||
| class BaseGenericModelChooserPanel(BaseChooserPanel): |
There was a problem hiding this comment.
Do we need separate panel and cant just use http://docs.wagtail.io/en/v1.7/topics/snippets.html for our models ?
There was a problem hiding this comment.
i doubt we can use snippets panel without actually using snippets
snippets is an easier approach
i think i should have used it instead of implementing this panel
but now when my widget is implemented, modeladmin approach opens more opportunities
|
@abitrolly is deploy/netlify failure expected? |
|
@davojta is this gtg? once we merge this i'll start converting data from |
|
I agree with that, go ahead ;-)
…On Thu, Dec 8, 2016, 5:10 PM Stas Rudakou ***@***.***> wrote:
@davojta <https://github.com/davojta> is this gtg? once we merge this
i'll start converting data from results
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#85 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA2i0muSpna1MTjxTX99gucePzV0zilGks5rGA_ngaJpZM4LHSiB>
.
|
|
@davojta could you please approve this then? :) |
davojta
approved these changes
Dec 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds cpm_data application to separate data from site structure. My final goal is to get rid of Page objects that don't represent public site pages.
This was inspired by site menu (developed by @abitrolly).
wagtail.contrib.modeladminprovides some tools for making independent admin-like CRUD interfaces (that still look like Wagtail). Looks like this module miss a lot of things. The main one is a generalized chooser panel (so I had to implement one). Also I miss Page-like revisions/publications.modeladminutilscontains our enahncements forwagtail.contrib.modeladmin. I'll probably try to push them back towagtail.contrib.modeladminsome time later.