exit status: return 'unknown' exit code (0) on timeout #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
We've noticed a strange behaviour where, if Kind2 times out, the exit code is 20 (safe). For some reason this only seems to happen when modular is true. We're worried about this because we're just checking the error codes, and this could hide some real issues.
I've tried to fix it by modifying
status_of_exn
in kind2Flow.ml so that it always returns "unknown" if the exception is a timeout.If you want to reproduce, I used this example locally:
On this (synthetic) timeout.lus which takes a while to verify or disprove:
on master I get the exit code 20 (safe):
I couldn't figure out how to write an automated test for this one because it requires the timeout. It also seems a bit fragile in case Kind2 solves it before the timeout. What do you think?
Thanks,
Amos