This repository has been archived by the owner on May 14, 2021. It is now read-only.
add metric type and additional information to /metrics endpoint #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cae6dcf.
up until now metrics didn't include the type (counter, gauge, timer histogram, etc.) this commit adds a new "type" field to every metrics object returned in /metrics endpoint. furthermore it also adds a "duration_unit" field for timer metrics. since timers uses golang's stdlib Time object, the unit is in nanoseconds. This commits reintroduces changes which were reverted in commit 6c37738, i reverted this for readability purposes since that commit didn't have a meaningful commit message and didn't explain what features it introduced. i'm reintroducing it now without but with a proper explanation. it's exactly the same feature as before
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up until now metrics didn't include the type (counter, gauge, timer histogram, etc.)
this commit adds a new "type" field to every metrics object returned in
/metrics endpoint.
furthermore it also adds a "duration_unit" field for timer metrics.
since timers uses golang's stdlib Time object, the unit is in nanoseconds.
This commits reintroduces changes which were reverted in commit 6c37738,
i reverted this for readability purposes since that commit didn't have a
meaningful commit message and didn't explain what features it introduced.
i'm reintroducing it now without but with a proper explanation.
it's exactly the same feature as before