Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a session, on opening the properties dialog, the custom label and icon are reset to default #12

Closed
danmur opened this issue Jul 28, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@danmur
Copy link

danmur commented Jul 28, 2020

Superb work btw :)

@danmur danmur changed the title When editing a session, on loading it, the custom label and icon are reset to default When editing a session, on opening the properties dialog, the custom label and icon are reset to default Jul 28, 2020
@kingToolbox
Copy link
Owner

Thank you. I noticed that when editing a session, switching to shell tab and back will cause the icon to be reset. I will fix this in the next version. But I cannot reproduce the custom label being reset. Would you like to describe this in more detail, thank you very much.

@danmur
Copy link
Author

danmur commented Jul 29, 2020

It only seems to happen with the shell tab. Here's steps to reproduce:

  1. Session -> new session
  2. Select shell tab
  3. Leave shell as cmd
  4. Change label to anything
  5. Change icon to anything
  6. Connect
  7. In the session pane open properties for the new session

When I do this the label has reset to cmd and the icon back to cmd icon.

Let me know if that doesn't do it, I can make screenshots.

@kingToolbox
Copy link
Owner

Thank you for describing the issue in detail. I have reproduced and fixed this. This will be released in the next version in early August.

@kingToolbox kingToolbox self-assigned this Jul 29, 2020
@kingToolbox kingToolbox added the bug Something isn't working label Jul 29, 2020
@kingToolbox
Copy link
Owner

The new version 1.5 has been released, please download and check, thank you.

@danmur
Copy link
Author

danmur commented Aug 22, 2020

Glorious :). Lots of other little rendering issues gone too, very nice.

@danmur danmur closed this as completed Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants