Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve keyboard-interactive multi-steps #632

Open
xiaosunzhu opened this issue Apr 2, 2022 · 5 comments
Open

improve keyboard-interactive multi-steps #632

xiaosunzhu opened this issue Apr 2, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@xiaosunzhu
Copy link

I have encountered a very inconvenient situation about keyboard-interactive.

  1. open session, enter username, prompt "YubiKey ....." on keyboard-interactive pop-up
  2. input yubikey, and next, according to the rule, need input account password, but nothing is responding on keyboard-interactive pop-up
  3. delete key in the input box manually, then input password and next, authetication success
...
[2022-04-02 11:31:55] ssh_packet_userauth_pk_ok: Received SSH_USERAUTH_PK_OK/INFO_REQUEST/GSSAPI_RESPONSE
[2022-04-02 11:31:55] ssh_packet_userauth_pk_ok: keyboard-interactive context, assuming SSH_USERAUTH_INFO_REQUEST
[2022-04-02 11:31:55] ssh_packet_userauth_info_request: 1 keyboard-interactive prompts
...
[2022-04-02 11:31:59] ssh_userauth_kbdint_send: Sending keyboard-interactive response packet
...
[2022-04-02 11:31:59] ssh_packet_userauth_pk_ok: Received SSH_USERAUTH_PK_OK/INFO_REQUEST/GSSAPI_RESPONSE
[2022-04-02 11:31:59] ssh_packet_userauth_pk_ok: keyboard-interactive context, assuming SSH_USERAUTH_INFO_REQUEST
[2022-04-02 11:31:59] ssh_packet_userauth_info_request: 1 keyboard-interactive prompts
...
[2022-04-02 11:32:07] ssh_userauth_kbdint_send: Sending keyboard-interactive response packet
...
[2022-04-02 11:32:07] ssh_packet_userauth_pk_ok: Received SSH_USERAUTH_PK_OK/INFO_REQUEST/GSSAPI_RESPONSE
[2022-04-02 11:32:07] ssh_packet_userauth_pk_ok: keyboard-interactive context, assuming SSH_USERAUTH_INFO_REQUEST
[2022-04-02 11:32:07] ssh_packet_userauth_info_request: 0 keyboard-interactive prompts
...
[2022-04-02 11:32:07] ssh_userauth_kbdint_send: Sending keyboard-interactive response packet
...
[2022-04-02 11:32:07] ssh_packet_userauth_success: Authentication successful
[2022-04-02 11:32:07] ssh_packet_userauth_success: Received SSH_USERAUTH_SUCCESS
...

Another little suggestion: why not save username for session?

@kingToolbox
Copy link
Owner

Sorry for the late reply. Recently I have been focusing on developing WindTerm_2.4.0_Prerelease_2.

I don't know why the server will reply ssh_packet_userauth_info_request: **0** keyboard-interactive prompts, have you tried any other SSH clients and how do they handle this?

If you only want to save the username for your sessions, please set the host of the session to user@host, e.g. root@127.0.0.1.

@xiaosunzhu
Copy link
Author

xiaosunzhu commented Apr 21, 2022

Thank you for the advice. user@host could store username indeed, but still need to confirm in popup.

There are 2 keyboard-interactive steps. Other ssh client is normal to process it, just pop up interactive twice.

@xiaosunzhu
Copy link
Author

Another one could improve:
I choose 'Attempt keyboard-interactive authentication' only, but 'Login' dialog default tab still 'Password', very inconvenient.

@kingToolbox
Copy link
Owner

I am happy to inform you that WindTerm_2.4.1 has been released and both of your proposals have been implemented. Please download and check it, thank you.

@kingToolbox kingToolbox self-assigned this Apr 25, 2022
@kingToolbox kingToolbox added the bug Something isn't working label Apr 25, 2022
@xiaosunzhu
Copy link
Author

Wow, thanks for the improvement.

I tried 2.4.1, the second issue have been fixed, great!
But the first one, keyboard-interactive multi-steps, still not show tip and clean input for next step, still need clean input manually.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants