-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use node-hue-api
#8
Conversation
- Refactors to use [`node-hue-api`](https://github.com/peter-murray/node-hue-api) package for simplified calls - Adds test coverage to all registered listeners - Improves output from scripts to no longer spit out raw JSON - Makes it slightly more polite 馃榿 Tested with Slack adapter and a hue starter kit. Fixes #1 by virtue of reducing backtalk to meaningful stuff.
@@ -45,20 +56,29 @@ To enable the script, add the `hubot-philipshue` entry to the `external-scripts. | |||
|
|||
Make an HTTP POST request of the following to http://YourHueHub/api | |||
|
|||
{"username": "YourHash", "devicetype": "YourAppName"} | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing json flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing this one and a few above it.
I like what you've done with the project by using |
Added some notes. Biggest addition in this PR may be that it now legitimately adds light groups to the bridge rather than an in-memory solution (that would be lost upon a reset of the Hubot). I don't have any apps (other than this one) that uses that for a particular purpose, but it's handy to be able to say |
I like the direction you went with node-hue-api. I'll work on a dynamic message solution when I get some time unless someone beats me to it. Thanks for your interest in the little project! :) |
node-hue-api
package for simplified callsTested with Slack adapter and a hue starter kit.
Fixes #1 by virtue of reducing backtalk to meaningful stuff.
Edit 1: Adds group note above