Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use node-hue-api #8

Merged
merged 3 commits into from
Jun 2, 2015
Merged

Refactor to use node-hue-api #8

merged 3 commits into from
Jun 2, 2015

Conversation

stephenyeargin
Copy link
Collaborator

  • Refactors to use node-hue-api package for simplified calls
  • Adds light groups to the bridge (rather than use an in-memory hash)
  • Adds test coverage to all registered listeners
  • Improves output from scripts to no longer spit out raw JSON
  • Makes it slightly more polite 馃榿

Tested with Slack adapter and a hue starter kit.

Fixes #1 by virtue of reducing backtalk to meaningful stuff.


Edit 1: Adds group note above

stephenyeargin and others added 2 commits May 25, 2015 17:12
- Refactors to use [`node-hue-api`](https://github.com/peter-murray/node-hue-api) package for simplified calls
- Adds test coverage to all registered listeners
- Improves output from scripts to no longer spit out raw JSON
- Makes it slightly more polite 馃榿

Tested with Slack adapter and a hue starter kit.

Fixes #1 by virtue of reducing backtalk to meaningful stuff.
@@ -45,20 +56,29 @@ To enable the script, add the `hubot-philipshue` entry to the `external-scripts.

Make an HTTP POST request of the following to http://YourHueHub/api

{"username": "YourHash", "devicetype": "YourAppName"}
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing json flag

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this one and a few above it.

@kingbin
Copy link
Owner

kingbin commented May 27, 2015

I like what you've done with the project by using node-hue-api. I made a couple suggestions that I saw when skimming through the updates. I was curious for your input. I don't mind accepting the merge request and hopefully getting around to working on those suggestions or allowing you to work on those pieces. I haven't touched this project in a while.
Thanks for your interest! 馃崶

@stephenyeargin
Copy link
Collaborator Author

Added some notes.

Biggest addition in this PR may be that it now legitimately adds light groups to the bridge rather than an in-memory solution (that would be lost upon a reset of the Hubot). I don't have any apps (other than this one) that uses that for a particular purpose, but it's handy to be able to say !hue @LivingRoom off.

@kingbin
Copy link
Owner

kingbin commented Jun 2, 2015

I like the direction you went with node-hue-api. I'll work on a dynamic message solution when I get some time unless someone beats me to it. Thanks for your interest in the little project! :)

kingbin added a commit that referenced this pull request Jun 2, 2015
Refactor to use `node-hue-api`
@kingbin kingbin merged commit b17b63c into kingbin:master Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I don't necessarily want to see backtalk
2 participants