-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve routing #100
Improve routing #100
Conversation
This allows for the index.html to be generated as a static page.
This is interesting (and good functionality) but I'm wondering about better solutions to two issues: A) The fact that we give numeric indexes special treatment in the first place. (E.g. instead of having a I'm going to spend a little time thinking about these. Thanks for sparking this discussion. |
a) I am not sure what you mean. I think it's pretty good the way it is, because it gives you quite a bit of flexibility in defining the layout of the rendered result. I don't really see how you could unify the routes and not pay the cost of limiting the flexibility. b) Well, you could use either functions or templates (I mean something like:
|
I think it is nice to merge this and consider the better solution later. |
the second commit (renaming the accessor) is unnecessary and inconsistent with other accessors. |
(or is it?) |
the usage for 1. is unclear. |
Here's a bunch of improvements to content routing that I find useful.
1. Blog index
I want my index.html to be a static page and, if I do so now, the first page of the numeric index gets overwritten. This is because coleslaw creates a symlink from index.html to the first page of the numeric index. This change allows you to specify a custom name or
nil
for the blog index.2. Point the blog index to the first page of the numeric index irrespective of the routing settings
This fixes the bug where the code assumes that the first page of the numeric index is always called
1.html
. However, this may not be be true, depending the routing settings.3. Allow for lambdas in routing settings
I really like having something like this: