Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize starter #9

Merged
merged 5 commits into from
Aug 27, 2018
Merged

Dockerize starter #9

merged 5 commits into from
Aug 27, 2018

Conversation

BolajiOlajide
Copy link
Contributor

@BolajiOlajide BolajiOlajide commented Aug 27, 2018

What does this PR do

Dockerize app

Description of Task to be completed

Dockerize app

How should this be manually tested

Running the docker instructions contained in the README

Any background context you want to add

Fixes this issue

Screenshots

N/A

Orjiewuru Kingdom Isaac and others added 5 commits August 23, 2018 11:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 31

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 29: 0.0%
Covered Lines: 6
Relevant Lines: 6

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 30

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 29: 0.0%
Covered Lines: 6
Relevant Lines: 6

💛 - Coveralls

@kingisaac95 kingisaac95 changed the base branch from master to feature/develop August 27, 2018 08:49
Copy link
Owner

@kingisaac95 kingisaac95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@kingisaac95 kingisaac95 merged commit 54914c7 into kingisaac95:feature/develop Aug 27, 2018
@BolajiOlajide BolajiOlajide deleted the dockerize-starter branch August 27, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants