Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate library jackc/pgx from v3 to v4 (v3 doesn't work on windows) #1

Closed
ilkhenrique opened this issue May 15, 2020 · 3 comments
Closed

Comments

@ilkhenrique
Copy link

Thank you very much for creating pgcat. It's fantastic.

Please migrate jackc/pgx from v3 to v4!
There are so many important fixes since v3. Also v3 does not work properly on windows.

Thank you again,
Dennis

@kingluo
Copy link
Owner

kingluo commented May 25, 2020

I would try to update pgx to v4. It would take me some time because v4 is breakage change from v3.

Also v3 does not work properly on windows.

I tested pgcat on Windows, and it seems that v3 works on Windows.
Could you clarify more where v3 does not work properly on Windows?

@kingluo
Copy link
Owner

kingluo commented May 28, 2020

I commit my changes, please have a check.

@kingluo kingluo closed this as completed Jun 9, 2020
@ilkhenrique
Copy link
Author

Thank you very much!!
I will check.

v3 seems to work but it does not. The problem is the way windows winsock return codes and when it returns.
Actually I made some workaround on pgx v3 to make it work, but not really fixes, just bypassed problematic situations.

Here the problem is reported:
https://gitmemory.com/issue/jackc/pgx/637/554683007

But it's said to have been fixed on v4 somewhere else
Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants