Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler_msvc & compiler_posix Use CRLF as EOL Instead of LF #2

Closed
kingsamchen opened this issue Sep 8, 2020 · 0 comments
Closed

compiler_msvc & compiler_posix Use CRLF as EOL Instead of LF #2

kingsamchen opened this issue Sep 8, 2020 · 0 comments
Assignees
@kingsamchen
Labels
bug Something isn't working

Comments

@kingsamchen
Copy link
Owner

anvil forces using LF as EOL for every generated file but compiler_msvc.cmake and compiler_posix.cmake incorrectly use CRLF as EOL.

Because their original file templates use LF and they contain some placeholder marks to be replaced with given project name during project bootstrap, its reasonable to doubt that the file modification changed file EOL.
@kingsamchen kingsamchen added the bug Something isn't working label Sep 8, 2020
@kingsamchen kingsamchen self-assigned this Sep 8, 2020
kingsamchen added a commit that referenced this issue Sep 8, 2020
@kingsamchen
Replace fileinput with more canonical file I/O for project-name repla…
4257eda 
…cement (#2)

This should fix the issue related to EOL change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingsamchen kingsamchen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kingsamchen