New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gcc build and tidy issues after upgrade to v17 #12

Merged

kingsamchen merged 1 commit into master from dev-fix-build

Jan 31, 2024

Owner

kingsamchen commented Jan 31, 2024

A move constructor with noexcept(false) but =default will still be treated as nothrow-move-constructible in gcc-11 (i.e. default gcc compiler on Ubuntu 22.04), so replace =default with explicit ctor body to address the issue.
After upgrading clang-tools to v17 there are new tidy checks failed and got fixed
Added/deleted headers as suggested by include-what-you-use


          Fix gcc build and tidy issues after upgrade to v17

b1cfcbb

kingsamchen merged commit f473cf8 into master

kingsamchen deleted the dev-fix-build branch

January 31, 2024 09:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment