New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow implicit construction from underlying handle value #15

Merged

kingsamchen merged 1 commit into master from improve-unique-handle

Apr 28, 2024

Owner

kingsamchen commented Apr 28, 2024 •

edited

Current implementation will make an expression like

bool ok = handle.get() == 1;

fail to compile, because there are two possible implicit conversions:

convert from 1 to unique handle
convert handle.get() to int value (underlying handle value)

Now that we have wrap_* functions, we can disallow implicit construction from underlying handle value


          Disallow implicit construction of unique handle from underlying handl…

f6806af

…e value

kingsamchen merged commit f3a9231 into master

kingsamchen deleted the improve-unique-handle branch

April 28, 2024 16:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment