Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*** Important Issues to be fixed #700

Closed
cdguy opened this issue Dec 22, 2023 · 9 comments
Closed

*** Important Issues to be fixed #700

cdguy opened this issue Dec 22, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@cdguy
Copy link

cdguy commented Dec 22, 2023

Hello @kingslay there a few major bugs that need to be fixed as high priority.

To make your work easier, I will regroup the issues here:

1- Progressive streams and media info

a) With the last commits, now all interlaced streams do not have fluid playback.

b) Your last commit (most probably the ffmpeg update) broke the media details

How to replicate:
i) while playing a stream open the media info details
ii) if you play a 50p progressive content; the “Video Track” field will display the video track as 25fps
iii) while playing a stream open the media info details
ii) if you play a 50i interlaced content; the “Video Track” field will display the video track as 50fps

This screenshot is from the tracyplayer testflight (this one should be displayed)
Previous Ksplayer

This screenshot is the untouched demo app with the latest code
Latest Ksplayer

2- HDR10+ issue

Until the tracy player build 85, HDR10+ is played correctly however with the build 86, HDR10+ layer is gone, the content is played as HDR standard
In order to be able to use the HDR10+ layer I have to switch back Asynchronous Decompression to ON.

I suspect you disabled Asynchronous Decompression because if you enable it, the #691 issue is happening.

3- Audio Unit issue
I deliberately closed the issue, but it is not fixed #698

I will share with you the links in an hour. I am compiling all the video files into one place.

Also I will create a kind of checklist for you. With this checklist, you will be able to run individual tests before each commit and to make sure that nothing is broken every time you update your code

@cdguy cdguy added the bug Something isn't working label Dec 22, 2023
@kingslay
Copy link
Owner

if you play a 50i interlaced content; the “Video Track” field will display the video track as 50fps
这样显示,不符合你的预期吗?我是有做了一个处理,如果使用 yadif_2x的话,那我会对fps 进行 fps = fps*2 的处理。 这样才能跟display fps显示的值一致

@kingslay
Copy link
Owner

kingslay commented Dec 22, 2023

如果是可以公开的测试视频,那可以上传到这个库里面https://github.com/kingslay/TestVideo 上传完之后。运行下swift main.swift 就能自动生成m3u8了。

@cdguy
Copy link
Author

cdguy commented Dec 22, 2023

if you play a 50i interlaced content; the “Video Track” field will display the video track as 50fps 这样显示,不符合你的预期吗?我是有做了一个处理,如果使用 yadif_2x的话,那我会对fps 进行 fps = fps*2 的处理。 这样才能跟display fps显示的值一致

I am sorry this is my mistake, it works fine. my livestreams got downgraded to 25p somehow... the behaviour is 100% correct for this

@cdguy
Copy link
Author

cdguy commented Dec 22, 2023

如果是可以公开的测试视频,那可以上传到这个库里面https://github.com/kingslay/TestVideo 上传完之后。运行下swift main.swift 就能自动生成m3u8了。

My files are huge. I have subscribed to a Webdav service. I will share the links with you in private

@kingslay
Copy link
Owner

@cdguy 麻烦给我一个正常的interlaced 的测试视频。我解决下你提的interlaced 播放不流程的问题

@cdguy
Copy link
Author

cdguy commented Dec 22, 2023

@kingslay I am sorry for the delay
the WEBDAW server limited my upload speed for the first hours
in 2 minutes I will send you the interlaced streams link and the Dolby Vision Files link

Thanks!!

@cdguy
Copy link
Author

cdguy commented Dec 23, 2023

if you play a 50i interlaced content; the “Video Track” field will display the video track as 50fps 这样显示,不符合你的预期吗?我是有做了一个处理,如果使用 yadif_2x的话,那我会对fps 进行 fps = fps*2 的处理。 这样才能跟display fps显示的值一致

can you please if you added this also into tvos? it seems like you only implement this on ios/ipados @kingslay

@kingslay
Copy link
Owner

tvOS也是会有这个能力的。所以应该是可以的。我回去检查下

@kingslay
Copy link
Owner

我用你发给我的Standard Interlaced Stream 在tvOS 试了 是可以显示为50fps的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants