-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Mesh.element_finder #667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinnala
commented
Jul 16, 2021
kinnala
commented
Jul 20, 2021
kinnala
commented
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a heuristic optimization in
MeshTri1.element_finder
andMeshTet1.element_finder
which tries to reduce the number of candidate elements where the query point may reside. The optimization logic looks for the query points inside elements whose midpoints are nearby. However, if the number of input points is large (in comparison to the number of elements), this "optimization" actually leads to a larger number of candidate elements and more memory being allocated.Moreover, it was pointed out in #666 that the optimization logic does not work for some meshes with degenerate elements.
MeshTri1
andMeshTet1
; compare againstscipy.spatial.Delaunay.find_simplex
MeshTet1.element_finder
While testing the new implementation it was found out that the optimization logic fails entirely for meshes that have less than 5 or 8 elements and raises error.
MeshTri1.element_finder
andMeshTet1.element_finder
for meshes that have a small number of elements.Moreover, as pointed out in #646, points outside of the mesh are not detected correctly.