Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop between container and no container since 3.4.0 #89

Closed
OdinGitDat opened this issue Sep 4, 2019 · 6 comments · Fixed by #90
Closed

Endless loop between container and no container since 3.4.0 #89

OdinGitDat opened this issue Sep 4, 2019 · 6 comments · Fixed by #90
Assignees
Labels

Comments

@OdinGitDat
Copy link

OdinGitDat commented Sep 4, 2019

I have my rules set up where some domains are sent to specific containers, everything that doesn't match a rule is opened without a container, e.g:

@.* , No Container
@.*(\.|\/)facebook\..*$ , Facebook
@.*(\.|\/)google\..*$ , Google

Now if I open a link from within a google or fb container it used to just open it outside any container. Since 3.4.0 update it goes into a loop where it switches back and forth endlessly.

Opening a fb link from within a google container still works as expected. So container to container is fine.

3.3.0 works fine.

@OdinGitDat OdinGitDat changed the title Endless loop between container and no container since FF69 Endless loop between container and no container since 3.4.0 Sep 4, 2019
@ColorfanXP
Copy link

I've been having the same issue as well today. Took me a bit to figure out it was containerise causing it.

@seascape
Copy link

seascape commented Sep 4, 2019

Containerise caused a similar issue maybe two months ago so it was my first suspect, so to speak. Glad to see it confirmed here, thank you.

@LoveIsGrief LoveIsGrief added the bug label Sep 5, 2019
@LoveIsGrief LoveIsGrief self-assigned this Sep 5, 2019
LoveIsGrief added a commit to LoveIsGrief/bifulushi that referenced this issue Sep 5, 2019
Passing the openerTabId without a cookieStoreId creates a tab in
 the same container as the opener. This isn't what we want when the tab
 is supposed to be opened without a container.

In the latter case we simply attempt to update the tab after creation.

 kintesh#89  - Endless loop between container and no container since 3.4.0
LoveIsGrief added a commit to LoveIsGrief/bifulushi that referenced this issue Sep 5, 2019
 kintesh#89  - Endless loop between container and no container since 3.4.0
@mrtootoo
Copy link

I currently have the same issue. I did not realize it was only happening with sites assigned to No Container until reading this thread. If I right click the link and select No Container to open in, the link opens as expected. But if I left click the link, say from within the Email container, the click opens a flickering endless loop tab. I see above issue is closed, did I miss the fix?

@LoveIsGrief
Copy link
Collaborator

LoveIsGrief commented Sep 10, 2019 via email

kintesh added a commit that referenced this issue Sep 11, 2019
…ontainer_and_no_container_since_3.4.0_

Fix #89 endless loop between container and no container since 3.4.0
@mrtootoo
Copy link

mrtootoo commented Oct 2, 2019

Nothing has been closed yet. We're waiting for the fix to be merged and released.

I still experience an endless loop between container and no container when left clicking on a link assigned to "No container". I probably don't understand this thread, but has a fix been released or still in the works?

@LoveIsGrief
Copy link
Collaborator

A new version exists, but it doesn't seem to have been released. Gotta wait on @kintesh to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants