Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make registration fails if quiet=TRUE #22

Closed
kinto-b opened this issue Nov 9, 2021 · 1 comment
Closed

Make registration fails if quiet=TRUE #22

kinto-b opened this issue Nov 9, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@kinto-b
Copy link
Owner

kinto-b commented Nov 9, 2021

I must've been asleep at the wheel when I wrote this control flow. It doesn't make any sense

if (!quiet) {
msg <- "`make_register()` called outside of a 'makepipe' pipeline"
if (exists("__makepipe_register__", parent.frame())) {
register_env <- get("__makepipe_register__", parent.frame())
if (!is.environment(register_env)) warning(msg, call. = FALSE)
} else {
warning(msg, call. = FALSE)
return(invisible(value))
}
}

@kinto-b kinto-b added the bug Something isn't working label Nov 9, 2021
@kinto-b kinto-b added this to the 0.0.6 milestone Nov 9, 2021
kinto-b added a commit that referenced this issue Nov 10, 2021
@kinto-b kinto-b closed this as completed Nov 22, 2021
@kinto-b
Copy link
Owner Author

kinto-b commented Nov 22, 2021

Will be in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant