This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
fix: await flush files when using --watch mode #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
#103 caused by emitting a file change event before flushing a disk.
In order to fix that, I use
awaitWriteFinish
option of chokidar.https://github.com/paulmillr/chokidar#performance
I set 1000ms as the
stabilityThreshold
, of which default value is 2000ms though.Because 2000ms is a bit long in our cases.
In my windows environment, 500ms also works fine but it depends on changes and device specs so I chosen 1000ms as the value safely.