Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Expose kintone-plugin-packer/from-manifest #49

Merged
merged 1 commit into from Mar 13, 2018

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Mar 12, 2018

When I use the Node API of kintone-plugin-packer, I have to create a buffer of a zipped contents.
In order to create the buffer, I have to implement a feature that is implemented in kintone-plugin-packer, which is a creating the buffer based on the manifest.json.

I think it would be nice if kintone-plugin-packer had an API to create a plugin from a path of a manifest.json.
This PR is to expose the API.

const packPluginFromManifest = require('kintone-plugin-packer/from-manifest');
packPluginFromManifest('path/to/manifest.json', privateKey).then(output => {
  console.log(output.id);
  fs.writeFileSync('./private.ppk', output.privateKey);
  fs.writeFileSync('./plugin.zip', output.plugin);
});

It's fine for me to expose createContentsZip but it seems to not be useful for others except me. :)

@teppeis teppeis merged commit 6154ed5 into master Mar 13, 2018
@teppeis teppeis deleted the pack-plugin-from-manifest-json branch March 13, 2018 01:53
@teppeis
Copy link
Contributor

teppeis commented Mar 13, 2018

@koba04 thanks! but it is not an formal API and may be implicitly changed or deleted in the future.

@koba04
Copy link
Contributor Author

koba04 commented Mar 13, 2018

@teppeis Thanks! Yes, it's not an ideal API interface. we should revamp the API to support more use-cases.

@teppeis
Copy link
Contributor

teppeis commented Mar 13, 2018

@koba04 released in v0.8.0!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants