Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

feat(cli): add --watch option to create a plugin zip automatically #70

Merged
merged 1 commit into from Mar 18, 2018

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Mar 16, 2018

I think it would be nice if kintone-plugin-packer had a --watch option, so I've added it.
Using this PR, developers no longer run kintone-plugin-packer command manually after each change.

It's very useful, isn't it?

In this PR, I've updated the interface of cli.js to return always a promise if an error occurred. Current implementation might throw errors so we have to care about a case throw errors using try-catch. I think returning an error as a rejected promise seems to be better than throw an error at the point of consistency. Even though it might be a breaking change.

@teppeis
Copy link
Contributor

teppeis commented Mar 18, 2018

snyk reported a security issue of chokidar, but it doesn't affect this package.

paulmillr/chokidar#686
fsevents/fsevents#198

@teppeis teppeis merged commit a0791fe into master Mar 18, 2018
@teppeis teppeis deleted the add-watch-option branch March 18, 2018 11:08
@koba04
Copy link
Contributor Author

koba04 commented Mar 19, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants