Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support request over proxy #25

Merged
merged 8 commits into from
Aug 10, 2022
Merged

chore: support request over proxy #25

merged 8 commits into from
Aug 10, 2022

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Aug 3, 2022

Why

Because cli-kintone v0 unofficially supports requests over proxy by setting the HTTPS_PROXY environment variable.
https://developer.cybozu.io/hc/ja/community/posts/115019277543

What

When the HTTPS_PROXY environment variable is set, cli-kintone sends requests over proxy

  • support proxy
    • --proxy cli option
    • HTTPS_PROXY environment variable
    • https_proxy environment variable
  • fix and add tests
  • update README.md

How to test

yarn install
yarn build

# configure by cli option
node ./cli.js record export --app $APP_ID --proxy <protocol://server:port>

# configure by HTTPS_PROXY environment varibale
HTTPS_PROXY=<protocol://server:port> node ./cli.js record export --app $APP_ID

# configure by https_proxy environment varibale
https_proxy=<protocol://server:port> node ./cli.js record export --app $APP_ID

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@tasshi-me tasshi-me marked this pull request as ready for review August 10, 2022 02:30
@tasshi-me tasshi-me requested review from a team and ueokande and removed request for a team August 10, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants