Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-uploader): change the way of clicking the "Import" button #1018

Merged
merged 5 commits into from
Jul 20, 2021
Merged

fix(plugin-uploader): change the way of clicking the "Import" button #1018

merged 5 commits into from
Jul 20, 2021

Conversation

chick-p
Copy link
Contributor

@chick-p chick-p commented Jul 20, 2021 •
edited
Loading

Why

Over Puppeteer 9.x, fail to upload a plugin file.
Because Puppeteer has fixed page.click() method to be called sequentially the move, down, and up method.
Ref. puppeteer/puppeteer#7097

On the other hand, Puppeteer 8.x fail to install in M1 mac.
Ref. puppeteer/puppeteer#6622

What

click "Import" button inside page.evaluate() instead of page.click()

How to test

yarn build
cd packages/plugin-uploader
bin/cli.js sample-plugin.zip

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@chick-p chick-p self-assigned this Jul 20, 2021
@chick-p chick-p requested review from a team, zaki-yama and tasshi-me and removed request for a team July 20, 2021 06:22
@github-actions github-actions bot added the pkg: plugin-uploader @kintone/plugin-uploader label Jul 20, 2021
@chick-p chick-p marked this pull request as draft July 20, 2021 06:23
@chick-p chick-p changed the title fix: page.click() not work well over puppeteer 9.x fix: "Import" button does not work over puppeteer 9.x Jul 20, 2021
@chick-p chick-p changed the title fix: "Import" button does not work over puppeteer 9.x fix(plugin-uploader): "Import" button does not work over puppeteer 9.x Jul 20, 2021
@chick-p chick-p marked this pull request as ready for review July 20, 2021 06:51
@zaki-yama zaki-yama changed the title fix(plugin-uploader): "Import" button does not work over puppeteer 9.x fix(plugin-uploader): change the way of clicking the "Import" button Jul 20, 2021
@zaki-yama zaki-yama merged commit af008e7 into master Jul 20, 2021
@zaki-yama zaki-yama deleted the update-puppeteer branch July 20, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaki-yama zaki-yama zaki-yama approved these changes

@tasshi-me tasshi-me Awaiting requested review from tasshi-me

Assignees

@chick-p chick-p

Labels
pkg: plugin-uploader @kintone/plugin-uploader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chick-p @zaki-yama @shintaroNagata