Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(webpack-plugin-kintone-plugin): fix failed test on windows #2718

Merged
merged 3 commits into from
Apr 22, 2024
Merged

test(webpack-plugin-kintone-plugin): fix failed test on windows #2718

merged 3 commits into from
Apr 22, 2024
+3 −1

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented Apr 22, 2024 •
edited
Loading

Why

  • Fix fail test on Windows
  • Following the 18.20.2/20.12.2 node.js releases, it is no longer valid to call child_process.spawn with a .cmd or .bat file without using the shell: true option.
    Ref: https://nodejs.org/en/blog/release/v18.20.2

What

  • Add shell: true to spawnSync configuration if OS is Windows.

How to test

pnpm test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and minh-nguyen1985 and removed request for a team April 22, 2024 03:08
@github-actions github-actions bot added the pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin label Apr 22, 2024
@aws-amplify-ap-northeast-1 AWS Amplify (ap-northeast-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2718.d1ite8zvzg8c5i.amplifyapp.com

@tuanphamcybozu tuanphamcybozu self-assigned this Apr 22, 2024
@hung-cybo hung-cybo changed the title ci: fix failed test on windows test(webpack-plugin-kintone-plugin): fix failed test on windows Apr 22, 2024
hung-cybo
hung-cybo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit e2a6370 into master Apr 22, 2024
11 checks passed
@hung-cybo hung-cybo deleted the ci/fix-failed-test-on-windows branch April 22, 2024 04:08
tuanphamcybozu added a commit that referenced this pull request May 8, 2024
@tuanphamcybozu
test(webpack-plugin-kintone-plugin): fix failed test on windows (#2718)
941c1ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

@minh-nguyen1985 minh-nguyen1985 Awaiting requested review from minh-nguyen1985

Assignees

@tuanphamcybozu tuanphamcybozu

Labels
pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tuanphamcybozu @hung-cybo