Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the response of the Get Space API #29

Merged
merged 2 commits into from
Jan 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ API client library for Kintone REST APIs on Java.
Add dependency declaration in `build.gradle` of your project.
```
dependencies {
implementation 'com.kintone:kintone-java-client:1.2.0'
implementation 'com.kintone:kintone-java-client:1.2.1'
}
```
- For projects using Maven
Expand All @@ -17,7 +17,7 @@ API client library for Kintone REST APIs on Java.
<dependency>
<groupId>com.kintone</groupId>
<artifactId>kintone-java-client</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ plugins {
id 'com.github.hierynomus.license' version '0.15.0'
}

version = '1.2.0'
version = '1.2.1'
sourceCompatibility = 1.8
targetCompatibility = 1.8

Expand Down
4 changes: 2 additions & 2 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ client.close();
Add dependency declaration in `build.gradle` of your project.
```groovy
dependencies {
implementation 'com.kintone:kintone-java-client:1.2.0'
implementation 'com.kintone:kintone-java-client:1.2.1'
}
```

Expand All @@ -39,7 +39,7 @@ Add dependency declaration in `pom.xml` of your project.
<dependency>
<groupId>com.kintone</groupId>
<artifactId>kintone-java-client</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
</dependency>
```

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,39 @@ public class GetSpaceResponseBody implements KintoneResponseBody {
* @return true if users cannot join/leave the Space or follow/unfollow threads.
*/
private final boolean fixedMember;

/**
* Whether the "Announcement" widget in the Space Portal page is shown.
*
* @return true if the "Announcement" widget is shown.
*/
private final boolean showAnnouncement;

/**
* Whether the "Apps" widget in the Space Portal page is shown.
*
* @return true if the "Apps" widget is shown.
*/
private final boolean showAppList;

/**
* Whether the "People" widget in the Space Portal page is shown.
*
* @return true if the "People" widget is shown.
*/
private final boolean showMemberList;

/**
* Whether the "Threads" widget in the Space Portal page is shown.
*
* @return true if the "Threads" widget is shown.
*/
private final boolean showThreadList;

/**
* Whether the "Related Apps & Spaces" widget in the Space Portal page is shown.
*
* @return true if the "Related Apps & Spaces" widget is shown.
*/
private final boolean showRelatedLinkList;
}
10 changes: 8 additions & 2 deletions src/test/java/com/kintone/client/SpaceClientTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,12 @@ public void getSpace_long() {
10,
false,
false,
false);
false,
true,
true,
true,
true,
true);
mockClient.setResponseBody(resp);

assertThat(sut.getSpace(10L)).isEqualTo(resp);
Expand All @@ -175,7 +180,8 @@ public void getSpace_GetSpaceRequest() {
GetSpaceRequest req = new GetSpaceRequest();
GetSpaceResponseBody resp =
new GetSpaceResponseBody(
1, "", 1, false, null, null, null, "", "", "", null, 1, false, false, false);
1, "", 1, false, null, null, null, "", "", "", null, 1, false, false, false, true, true,
true, true, true);
mockClient.setResponseBody(resp);

assertThat(sut.getSpace(req)).isEqualTo(resp);
Expand Down