-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cchardet alternatives for python 3.11+ #543
Comments
Additional DataTried install Lasio requirements in a Python 3.11 venv. Below is the full cChardet install error. The critical failure is:
Full Output:
|
Maybe we can make it simpler and just use chardet if it is installed, and if not, give an error? |
Do you mean, "use chardet if it is installed" or "use cchardet if it is installed"? |
Notes: The pyproject.toml syntax below may work. For now (lasio main), it needs to be in setup.py format. So look that up! [project.optional-dependencies]
cchardet = [
'cchardet; python_version < "3.11"',
] References: |
I meant the former, since the cchardet fork isn't fully cross-platform, so trying to use it or recommend it for python 3.11 would probably create more problems than it helps with? Not sure what to do! |
I'll make a branch replacing |
Describe the bug
For python 3.11 cChardet fails to build. The error message is:
cchardet.cpp(196): fatal error C1083: Cannot open include file: 'longintrepr.h': No such file or directory.
In addition, the cchardet doesn't seem to be currently maintained.
This is a problem that will need to be resolved going forward.
faust-streaming/cChardet
is a possible replacement. It is a fork of cChardet.https://pypi.org/project/faust-cchardet/
https://github.com/faust-streaming/cChardet
Notes
Does not Support
Anaconda
pyenv
Does not yet install on MacOS
Cannot install on arm64 (Apple M1 Sillicon) #12
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Python 3.11 builds/test on GitHub->Actions->Python CI should should pass
Software versions (please complete the following information):
Additional context
chardet
is a slower fall back option. So there is a possibility that Lasio code/packaging can be arranged to usechardet
on Python 3.11.The text was updated successfully, but these errors were encountered: