This repository has been archived by the owner on May 6, 2020. It is now read-only.
packet: pass tags to packet_device #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some applications (such as autoscaler) may require Packet tags to be set. To avoid having additional tooling to tag the instances we can pass tags directly to packet_device. Signed-off-by: Martin Polednik <m.polednik@gmail.com>
invidian
requested review from
mauriciovasquezbernal,
rata,
ipochi and
surajssd
alban
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Hi @mpolednik ,
Sorry I hadn't noticed your PR and I had created a similar PR (#179). Your PR looks good to me. I suggest we merge it first if other reviewers agree.
invidian
approved these changes
Feb 14, 2020
rata
approved these changes
Feb 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications (such as autoscaler) may require Packet tags to be
set. To avoid having additional tooling to tag the instances we can
pass tags directly to packet_device.
Signed-off-by: Martin Polednik m.polednik@gmail.com