Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search is not working on Android. #42

Closed
ashu17706 opened this issue Jul 18, 2017 · 2 comments
Closed

Search is not working on Android. #42

ashu17706 opened this issue Jul 18, 2017 · 2 comments

Comments

@ashu17706
Copy link

Hey! I just came across this repo. Nice implementation Man!
I just found that search is not working on Android Phones.
@kiok46
Copy link
Owner

kiok46 commented Jul 18, 2017 •
edited

Thanks @ashu17706 ,
It's using a sample data which is in constants/data.json

You can use DuckDuckGo's API or any other API api by updating the SearchList component from here componentWillMount when onSubmitEditingSearch gets called.

Showing the search results wasn't the main goal but the UI when building the app. But sure PR is welcome. :)

@kiok46
Copy link
Owner

kiok46 commented Nov 17, 2017

Hi,
Added this in the readme: https://github.com/kiok46/duckduckgo#does-search-work
Closing this issue.

Have a great day 😸

@kiok46 kiok46 closed this as completed Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kiok46 @ashu17706