Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix Money to Subscription exception modules #75

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

Joe-noh
Copy link
Contributor

@Joe-noh Joe-noh commented Aug 15, 2018

I got following error while playing around Money.Subscription functions.

iex(17)> Money.Subscription.change_plan!(s, new, current_interval_started: ~D[2018-01-01]) |>  Money.Subscription.change_plan!(current, current_interval_started: ~D[2018-09-01])
** (UndefinedFunctionError) function Money.Subscription.PlanPending.exception/1 is undefined (module Money.Subscription.PlanPending is not available)
    Money.Subscription.PlanPending.exception("Can't change plan when a new plan is already pending")
    (ex_money) lib/money/subscription.ex:660: Money.Subscription.change_plan!/3

This is not desired behavior and these exceptions have to have Money prefix. Please correct me if I misunderstood. thanks.

(Tests have been passed due to this alias so far?)

@kipcole9 kipcole9 merged commit 36aadd6 into kipcole9:master Aug 15, 2018
kipcole9 added a commit that referenced this pull request Aug 15, 2018
@kipcole9
Copy link
Owner

@Joe-noh Thanks much for the bug report and PR. Merged and released on Hex as version 2.7.1

@Joe-noh Joe-noh deleted the exception-module-namespace branch August 18, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants