Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set packet data/optional default value in create() #71

Merged
merged 1 commit into from Jan 4, 2018

Conversation

the01
Copy link
Contributor

@the01 the01 commented Jan 3, 2018

Calling the Packet.create() method causes the logger to emit warnings about using default values for Packet.data and Packet.optional when instantiating the new packet.
This uses the default value [] explicitly to stop the warnings.

@coveralls
Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage remained the same at 91.316% when pulling a800ced on the01:master into 38d1852 on kipe:master.

@kipe
Copy link
Owner

kipe commented Jan 4, 2018

Thanks, looks good 👍

@kipe kipe merged commit 59020a2 into kipe:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants