ESP2 Protocol with Eltako Manufacturer Device Classes #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core ESP2 parts contributed wich stayed untouched compared to my local stuff. Other examples got stripped down and commited as-is as a usage reference and/or snippet lib for other people.
1 similar comment
|
See discussion in #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core ESP2 parts contributed wich stayed untouched compared to my local stuff. Other examples got stripped down and commited as-is as a usage reference and/or snippet lib for other people.
WARNING: MQTT in examples and message topic names in manufacturer classes. Needs makeover to be more generic.
I suggest that you create a new branch, work from there on and merge the ESP2 stuff when it's cleaned up. I rebased properly so things don't brake... plus, I cloned the classes for handling ESP2 communications. Feel free to re-join them with the existing communicator and serialcommunicator classes with extra mandatory switches for the protocol version. But this is tested in a large installation with over 80 Input Channels and close to 40 actors - also heating and shutters involved and the "multisensor" from eltako.
Thanks for all the work from you guys - the existing codebase for ESP3 was an amazing point to start from.