Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motor speeds not capped at 100% #88

Closed
tcorbly opened this issue Apr 23, 2021 · 1 comment · Fixed by #93
Closed

Motor speeds not capped at 100% #88

tcorbly opened this issue Apr 23, 2021 · 1 comment · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@tcorbly
Copy link
Member

tcorbly commented Apr 23, 2021

Motor speeds aren't capped at 100 which also causes unintentional sliding when they move too fast. Test at speeds of 500 or 1000 to replicate.

@tcorbly tcorbly added the bug Something isn't working label Apr 23, 2021
@tcorbly tcorbly added this to To do in 3D Simulator via automation Apr 23, 2021
@navzam
Copy link
Member

navzam commented Apr 24, 2021

I feel like libwallaby should be responsible for capping, since it should probably be capped on controllers too. Should we open a libwallaby issue to go along with this?

Though it wouldn't hurt to add a check in the simulator too.

@navzam navzam moved this from To do to In progress in 3D Simulator Apr 28, 2021
@navzam navzam self-assigned this Apr 28, 2021
@navzam navzam moved this from In progress to In Review in 3D Simulator Apr 28, 2021
3D Simulator automation moved this from In Review to Done Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants