argv-parser-rewrite #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiprasmel
force-pushed
the
argv-parser-rewrite
branch
3 times, most recently
from
966c3c1
to
922ef25
Compare
kiprasmel
force-pushed
the
argv-parser-rewrite
branch
2 times, most recently
from
41c425c
to
f3d9bff
Compare
…t process previously, if some error occurred, would just continue running, unless: a) a node arg `--unhandled-rejections=strict` was specified, or b) node version was >= 15 (but would get stuck, instead of exiting properly) for A, see: https://nodejs.org/api/cli.html#--unhandled-rejectionsmode now, always exits properly.
… w/o initialBranch if cached
...as long as the initialBranch was already provided
in some previous invocation of stacked-rebase, thus cached.
sometime later, we could have a config for the default initial branch..
- create generic utils for argv parsing (separate package soon?)
- introduce multiple tests, which caught lots of (mostly new) bugs!
- tidy up code at start of gitStackedRebase, which now makes great sense & looks nice
- same in other places
- clear up mental model of "parsing options" - it's "resolve" instead of "parse"
- move initialBranch parsing into resolveOptions
- don't want out of sync `resolvedOptions.initialBranch` vs `nameOfInitialBranch`
- get rid of "intial branch is optional for some args" -- non issue
- because e.g. for --continue to have any meaning, you'd have to have already
started a stacked rebase & thus would have the initial branch cached.
kiprasmel
force-pushed
the
argv-parser-rewrite
branch
from
f3d9bff
to
696ef74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: completely overhaul arg parsing & allow invoking CLI w/o initialBranch
...as long as the initialBranch was already provided
in some previous invocation of stacked-rebase, thus cached.
sometime later, we could have a config for the default initial branch..
create generic utils for argv parsing (separate package soon?)
introduce multiple tests, which caught lots of (mostly new) bugs!
tidy up code at start of gitStackedRebase, which now makes great sense & looks nice
clear up mental model of "parsing options" - it's "resolve" instead of "parse"
move initialBranch parsing into resolveOptions
resolvedOptions.initialBranchvsnameOfInitialBranchget rid of "intial branch is optional for some args" -- non issue
started a stacked rebase & thus would have the initial branch cached.