Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize url and video id changes #2

Merged
merged 4 commits into from
May 19, 2023
Merged

Optimize url and video id changes #2

merged 4 commits into from
May 19, 2023

Conversation

kiranparajuli589
Copy link
Owner

With this PR:

  • Make use of debounced function for URL and VideoID change handlers
  • Validate props and then only go to the player creating part.
  • Do not create or update the player if the URL is not a valid one.

@kiranparajuli589
Optimize url and video id changes
654822f 
Signed-off-by: Parajuli Kiran <kiranparajuli589@gmail.com>
@kiranparajuli589
Update the build code
927e9cf
@kiranparajuli589
Eslint fixes
efbb375 
Signed-off-by: Parajuli Kiran <kiranparajuli589@gmail.com>
@kiranparajuli589 kiranparajuli589 merged commit a7f8bb5 into master May 19, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the optimize-url-and-id-changes branch May 19, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kiranparajuli589